Fix array-to-List bug and clarify synchronous usage in “Async” classes #2822
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kimsunghyun <[email protected]>
kimsunghyun1995
force-pushed
the
fix/arrayToList
branch
from
4438b6b to
f8dc0d2
Compare
|
@kimsunghyun1995 I've added few tests, like: But they seems to show correct behavior from the existing code. Can you please add a test to show the #2822 (comment) issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array to List conversion
Updated methods like getToolCallbacksFromSyncClients to flatten ToolCallback[] properly using Arrays.asList(...) or streams.
Previously, using List.of(array) created a single-element list wrapping the entire array, causing incorrect behavior.